Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DXP-1420 list params for campaign_id and status #473

Merged
merged 4 commits into from
Nov 28, 2023
Merged

Conversation

mike-r-morgan
Copy link
Contributor

Fixes #<INSERT ISSUE NUMBER HERE>

Checklist

  • Up to date with main
  • All the tests are passing
    • Delete all resources created in tests
  • Prettier
  • Spectral Lint
  • npm run bundle outputs nothing suspect
  • npm run postman outputs nothing suspect

Changes

  • add campaign_id and status to shared resources.
  • Implement campaign_id and status for list endpoints for letters, postcards, and self-mailers
  • Implement status for checks list endpoint
  • existing retrieve endpoints now point to shared resource for status param in response

Areas of Concern (optional)

the tests did not pass

  ✖ create, retrieve, update, then delete a campaign 
  ─

  errors when schedule_type is not passed in

  tests/campaigns_test.js:204

   203:                                                                     
   204:     t.assert(response.status === 422);                              
   205:     t.assert(response.data.error.message.includes("schedule_type"));

  Value is not truthy:

  false

  › tests/campaigns_test.js:204:7



  list campaigns params

  tests/campaigns_test.js:118

   117:                                         
   118:       t.assert(response.status === 200);
   119:       return response.data;             

  Value is not truthy:

  false

  › list (tests/campaigns_test.js:118:9)
  › async tests/campaigns_test.js:171:20



  create, retrieve, update, then delete a campaign

  tests/campaigns_test.js:62

   61:                                       
   62:     t.assert(response.status === 200);
   63:                                       

  Value is not truthy:

  false

  › tests/campaigns_test.js:62:7

  ─

  3 tests failed

This was present before changes

dist/lob-api-bundled.yml Outdated Show resolved Hide resolved
dist/lob-api-bundled.yml Outdated Show resolved Hide resolved
@mike-r-morgan mike-r-morgan merged commit 0a45ea8 into main Nov 28, 2023
2 checks passed
@mike-r-morgan mike-r-morgan deleted the DXP-1420 branch November 28, 2023 00:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants